test_cli_roundtrip.cpp File Reference

Catch2 round-trip integrity tests for conversion CLI tools. More...

#include <kcenon/pacs/core/dicom_file.h>
#include <kcenon/pacs/core/dicom_tag_constants.h>
#include <catch2/catch_test_macros.hpp>
#include <array>
#include <chrono>
#include <cstdio>
#include <cstdlib>
#include <filesystem>
#include <string>
#include <thread>
#include <vector>
#include <sys/wait.h>

Include dependency graph for test_cli_roundtrip.cpp:

Go to the source code of this file.

Functions
	TEST_CASE ("JSON round-trip preserves metadata", "[cli][roundtrip]")
	TEST_CASE ("XML round-trip preserves metadata", "[cli][roundtrip]")
	TEST_CASE ("Transfer Syntax conversion preserves tags", "[cli][roundtrip]")
	TEST_CASE ("Anonymization changes patient identifiers", "[cli][roundtrip]")
	TEST_CASE ("Tag modification updates values correctly", "[cli][roundtrip]")

Detailed Description

Catch2 round-trip integrity tests for conversion CLI tools.

Verifies data integrity through CLI conversion round-trips: DCM->JSON->DCM, DCM->XML->DCM, Transfer Syntax conversion, anonymization, and tag modification.

Uses the PACS library API to programmatically compare input/output datasets at the tag level.

See also

Issue #759 - Add Catch2 round-trip integrity tests for conversion CLIs

Issue #756 - Automated CLI Tool Testing (Epic)

Definition in file test_cli_roundtrip.cpp.

Function Documentation

TEST_CASE() [1/5]

TEST_CASE	(	"Anonymization changes patient identifiers"	,
		""	[cli][roundtrip] )

Definition at line 268 of file test_cli_roundtrip.cpp.

                                                                           {
    temp_dir tmp;
    auto src = test_data_dir / "ct_minimal.dcm";
    auto anon_path = tmp.path / "anonymized.dcm";
 
    REQUIRE(fs::exists(src));
 
    // Anonymize
    auto result = run_cli("dcm_anonymize",
        {src.string(), anon_path.string()});
    INFO("dcm_anonymize output: " << result.output);
    REQUIRE(result.exit_code == 0);
    REQUIRE(fs::exists(anon_path));
 
    // Verify anonymization
    auto original = read_dicom(src);
    auto anonymized = read_dicom(anon_path);
 
    auto orig_name = get_tag(original, kcenon::pacs::core::tags::patient_name);
    auto anon_name = get_tag(anonymized, kcenon::pacs::core::tags::patient_name);
 
    // Patient name must be different after anonymization
    CHECK(orig_name != anon_name);
 
    // Anonymized file must still be valid DICOM (modality preserved)
    CHECK_FALSE(get_tag(anonymized, kcenon::pacs::core::tags::modality).empty());
}

References kcenon::pacs::core::tags::modality, and kcenon::pacs::core::tags::patient_name.

TEST_CASE() [2/5]

TEST_CASE	(	"JSON round-trip preserves metadata"	,
		""	[cli][roundtrip] )

Definition at line 161 of file test_cli_roundtrip.cpp.

                                                                    {
    temp_dir tmp;
    auto src = test_data_dir / "ct_minimal.dcm";
    auto json_path = tmp.path / "ct.json";
    auto dcm_path = tmp.path / "roundtrip.dcm";
 
    REQUIRE(fs::exists(src));
 
    // DCM -> JSON
    auto to_json = run_cli("dcm_to_json",
        {src.string(), json_path.string(), "--pretty", "--no-pixel"});
    INFO("dcm_to_json output: " << to_json.output);
    REQUIRE(to_json.exit_code == 0);
    REQUIRE(fs::exists(json_path));
 
    // JSON -> DCM
    auto to_dcm = run_cli("json_to_dcm",
        {json_path.string(), dcm_path.string()});
    INFO("json_to_dcm output: " << to_dcm.output);
    REQUIRE(to_dcm.exit_code == 0);
    REQUIRE(fs::exists(dcm_path));
 
    // Compare tags
    auto original = read_dicom(src);
    auto roundtrip = read_dicom(dcm_path);
 
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_name)
       == get_tag(roundtrip, kcenon::pacs::core::tags::patient_name));
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_id)
       == get_tag(roundtrip, kcenon::pacs::core::tags::patient_id));
    CHECK(get_tag(original, kcenon::pacs::core::tags::modality)
       == get_tag(roundtrip, kcenon::pacs::core::tags::modality));
    CHECK(get_tag(original, kcenon::pacs::core::tags::study_date)
       == get_tag(roundtrip, kcenon::pacs::core::tags::study_date));
}

References kcenon::pacs::core::tags::modality, kcenon::pacs::core::tags::patient_id, kcenon::pacs::core::tags::patient_name, and kcenon::pacs::core::tags::study_date.

TEST_CASE() [3/5]

TEST_CASE	(	"Tag modification updates values correctly"	,
		""	[cli][roundtrip] )

Definition at line 296 of file test_cli_roundtrip.cpp.

                                                                           {
    temp_dir tmp;
    auto src = test_data_dir / "ct_minimal.dcm";
    auto modified_path = tmp.path / "modified.dcm";
 
    REQUIRE(fs::exists(src));
 
    const std::string new_name = "ROUNDTRIP^TEST";
 
    // Modify PatientName
    auto result = run_cli("dcm_modify",
        {"-i", "(0010,0010)=" + new_name, "-o", modified_path.string(),
         src.string()});
    INFO("dcm_modify output: " << result.output);
    REQUIRE(result.exit_code == 0);
    REQUIRE(fs::exists(modified_path));
 
    // Verify modification
    auto modified = read_dicom(modified_path);
    CHECK(get_tag(modified, kcenon::pacs::core::tags::patient_name) == new_name);
 
    // Other tags should be unchanged
    auto original = read_dicom(src);
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_id)
       == get_tag(modified, kcenon::pacs::core::tags::patient_id));
    CHECK(get_tag(original, kcenon::pacs::core::tags::modality)
       == get_tag(modified, kcenon::pacs::core::tags::modality));
}

References kcenon::pacs::core::tags::modality, kcenon::pacs::core::tags::patient_id, and kcenon::pacs::core::tags::patient_name.

TEST_CASE() [4/5]

TEST_CASE	(	"Transfer Syntax conversion preserves tags"	,
		""	[cli][roundtrip] )

Definition at line 231 of file test_cli_roundtrip.cpp.

                                                                           {
    temp_dir tmp;
    auto src = test_data_dir / "ct_minimal.dcm";
    auto explicit_path = tmp.path / "explicit.dcm";
    auto implicit_path = tmp.path / "implicit.dcm";
 
    REQUIRE(fs::exists(src));
 
    // Convert to Explicit VR LE
    auto to_explicit = run_cli("dcm_conv",
        {src.string(), explicit_path.string(), "--explicit"});
    INFO("dcm_conv --explicit output: " << to_explicit.output);
    REQUIRE(to_explicit.exit_code == 0);
    REQUIRE(fs::exists(explicit_path));
 
    // Convert back to Implicit VR LE
    auto to_implicit = run_cli("dcm_conv",
        {explicit_path.string(), implicit_path.string(), "--implicit"});
    INFO("dcm_conv --implicit output: " << to_implicit.output);
    REQUIRE(to_implicit.exit_code == 0);
    REQUIRE(fs::exists(implicit_path));
 
    // Verify both outputs are valid DICOM with preserved tags
    auto original = read_dicom(src);
    auto explicit_file = read_dicom(explicit_path);
    auto implicit_file = read_dicom(implicit_path);
 
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_name)
       == get_tag(explicit_file, kcenon::pacs::core::tags::patient_name));
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_name)
       == get_tag(implicit_file, kcenon::pacs::core::tags::patient_name));
    CHECK(get_tag(original, kcenon::pacs::core::tags::modality)
       == get_tag(implicit_file, kcenon::pacs::core::tags::modality));
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_id)
       == get_tag(implicit_file, kcenon::pacs::core::tags::patient_id));
}

References kcenon::pacs::core::tags::modality, kcenon::pacs::core::tags::patient_id, and kcenon::pacs::core::tags::patient_name.

TEST_CASE() [5/5]

TEST_CASE	(	"XML round-trip preserves metadata"	,
		""	[cli][roundtrip] )

Definition at line 197 of file test_cli_roundtrip.cpp.

                                                                   {
    temp_dir tmp;
    auto src = test_data_dir / "mr_minimal.dcm";
    auto xml_path = tmp.path / "mr.xml";
    auto dcm_path = tmp.path / "roundtrip.dcm";
 
    REQUIRE(fs::exists(src));
 
    // DCM -> XML
    auto to_xml = run_cli("dcm_to_xml",
        {src.string(), xml_path.string(), "--no-pixel"});
    INFO("dcm_to_xml output: " << to_xml.output);
    REQUIRE(to_xml.exit_code == 0);
    REQUIRE(fs::exists(xml_path));
 
    // XML -> DCM
    auto to_dcm = run_cli("xml_to_dcm",
        {xml_path.string(), dcm_path.string()});
    INFO("xml_to_dcm output: " << to_dcm.output);
    REQUIRE(to_dcm.exit_code == 0);
    REQUIRE(fs::exists(dcm_path));
 
    // Compare tags
    auto original = read_dicom(src);
    auto roundtrip = read_dicom(dcm_path);
 
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_name)
       == get_tag(roundtrip, kcenon::pacs::core::tags::patient_name));
    CHECK(get_tag(original, kcenon::pacs::core::tags::patient_id)
       == get_tag(roundtrip, kcenon::pacs::core::tags::patient_id));
    CHECK(get_tag(original, kcenon::pacs::core::tags::modality)
       == get_tag(roundtrip, kcenon::pacs::core::tags::modality));
}

References kcenon::pacs::core::tags::modality, kcenon::pacs::core::tags::patient_id, and kcenon::pacs::core::tags::patient_name.